feat(generated): Add Pipes operations and models#413
Conversation
Greptile SummaryThis PR adds generated Pipes support for data integrations and connected account imports. The main changes are:
Confidence Score: 4/5Mostly safe to merge after addressing the connected account organization scoping issue. The generated models and endpoint coverage are straightforward, but one request-building path appears to ignore a documented organization scope parameter for connected account imports. lib/Service/Pipes.php
 T-Rex LogsWhat T-Rex did
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
lib/Service/Pipes.php:348-354
**Include organization scope**
`createUserConnectedAccount()` accepts `organizationId` and documents it as the way to scope the imported connection, but the request body never includes `organization_id`. When a caller passes an organization ID, the request still creates an unscoped user-level connected account because lines 348-354 only serialize tokens, scopes, and state. `updateUserConnectedAccount()` has the same omission below.
Reviews (1): Last reviewed commit: "chore(generated): add release notes frag..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| $body = array_filter([ | ||
| 'access_token' => $accessToken, | ||
| 'refresh_token' => $refreshToken, | ||
| 'expires_at' => $expiresAt?->format(\DateTimeInterface::RFC3339_EXTENDED), | ||
| 'scopes' => $scopes, | ||
| 'state' => $state?->value, | ||
| ], fn ($v) => $v !== null); |
There was a problem hiding this comment.
createUserConnectedAccount() accepts organizationId and documents it as the way to scope the imported connection, but the request body never includes organization_id. When a caller passes an organization ID, the request still creates an unscoped user-level connected account because lines 348-354 only serialize tokens, scopes, and state. updateUserConnectedAccount() has the same omission below.
Prompt To Fix With AI
This is a comment left during a code review.
Path: lib/Service/Pipes.php
Line: 348-354
Comment:
**Include organization scope**
`createUserConnectedAccount()` accepts `organizationId` and documents it as the way to scope the imported connection, but the request body never includes `organization_id`. When a caller passes an organization ID, the request still creates an unscoped user-level connected account because lines 348-354 only serialize tokens, scopes, and state. `updateUserConnectedAccount()` has the same omission below.
How can I resolve this? If you propose a fix, please make it concise.
Summary
feat(pipes): Add Pipes operations and models
DataIntegrationCredentialsDto.CustomProviderDefinition.CreateDataIntegration.UpdateCustomProviderDefinition.UpdateDataIntegration.DataIntegration.DataIntegrationList.DataIntegrationListListMetadata.DataIntegrationCredential.DataIntegrationCustomProvider.DataIntegrationCredentialsType.CustomProviderDefinitionAuthenticateVia.UpdateCustomProviderDefinitionAuthenticateVia.DataIntegrationState.DataIntegrationCredentialType.DataIntegrationCustomProviderAuthenticateVia.GET /data-integrations.POST /data-integrations.GET /data-integrations/{slug}.PUT /data-integrations/{slug}.DELETE /data-integrations/{slug}.POST /user_management/users/{user_id}/connected_accounts/{slug}.PUT /user_management/users/{user_id}/connected_accounts/{slug}.Triggered by workos/openapi-spec@e350eb0
BEGIN_COMMIT_OVERRIDE
feat(pipes): Add Pipes operations and models (#413)
END_COMMIT_OVERRIDE